<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Ensure a response MIME type when Content-Type is missing and sniffing not allowed"
href="https://bugs.webkit.org/show_bug.cgi?id=168299">bug 168299</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #301481 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Ensure a response MIME type when Content-Type is missing and sniffing not allowed"
href="https://bugs.webkit.org/show_bug.cgi?id=168299#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Ensure a response MIME type when Content-Type is missing and sniffing not allowed"
href="https://bugs.webkit.org/show_bug.cgi?id=168299">bug 168299</a>
from <span class="vcard"><a class="email" href="mailto:svillar@igalia.com" title="Sergio Villar Senin <svillar@igalia.com>"> <span class="fn">Sergio Villar Senin</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301481&action=diff" name="attach_301481" title="Patch">attachment 301481</a> <a href="attachment.cgi?id=301481&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301481&action=review">https://bugs.webkit.org/attachment.cgi?id=301481&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp:334
> + }</span >
What about just adding
if (m_response.mimeType().isEmpty() && m_soupMessage->status_code != SOUP_STATUS_NOT_MODIFIED)
m_response.setMimeType(MIMETypeRegistry::getMIMETypeForPath(m_response.url().path()));
to the previous code? I prefer that option because it clearly shows that the call to updateFromSoupMessage is unconditional.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>