[Webkit-unassigned] [Bug 168229] CookieManager only works with the default session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168229

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 301344
  --> https://bugs.webkit.org/attachment.cgi?id=301344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301344&action=review

Nice work! I trust you'll find an owner to review it.

Any reason you used std::function instead of the preferred WTF::Function?

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:46
> +    static NeverDestroyed<HashMap<CFHTTPCookieStorageRef, std::function<void ()>>> map;

You need to fix Windows:

C:\cygwin\home\buildbot\WebKit\Source\WebCore\platform\network\cf\CookieStorageCFNet.cpp(46): error C2079: 'map' uses undefined class 'WTF::NeverDestroyed<WTF::HashMap<CFHTTPCookieStorageRef,std::function<void (void)>,WTF::PtrHash<P *>,WTF::HashTraits<KeyArg>,WTF::HashTraits<MappedArg>>>' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
          with
          [
              P=OpaqueCFHTTPCookieStorage,
              KeyArg=CFHTTPCookieStorageRef,
              MappedArg=std::function<void (void)>
          ]

Probably a missing #include?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170214/ccc793a9/attachment-0001.html>