<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - CookieManager only works with the default session"
href="https://bugs.webkit.org/show_bug.cgi?id=168229#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - CookieManager only works with the default session"
href="https://bugs.webkit.org/show_bug.cgi?id=168229">bug 168229</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301344&action=diff" name="attach_301344" title="Patch">attachment 301344</a> <a href="attachment.cgi?id=301344&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301344&action=review">https://bugs.webkit.org/attachment.cgi?id=301344&action=review</a>
Nice work! I trust you'll find an owner to review it.
Any reason you used std::function instead of the preferred WTF::Function?
<span class="quote">> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:46
> + static NeverDestroyed<HashMap<CFHTTPCookieStorageRef, std::function<void ()>>> map;</span >
You need to fix Windows:
C:\cygwin\home\buildbot\WebKit\Source\WebCore\platform\network\cf\CookieStorageCFNet.cpp(46): error C2079: 'map' uses undefined class 'WTF::NeverDestroyed<WTF::HashMap<CFHTTPCookieStorageRef,std::function<void (void)>,WTF::PtrHash<P *>,WTF::HashTraits<KeyArg>,WTF::HashTraits<MappedArg>>>' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
with
[
P=OpaqueCFHTTPCookieStorage,
KeyArg=CFHTTPCookieStorageRef,
MappedArg=std::function<void (void)>
]
Probably a missing #include?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>