[Webkit-unassigned] [Bug 168015] [GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168015

--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
(In reply to comment #6)
> In any case, shouldn't the define GST_CAT_DEFAULT be still needed? I've
> 
> This seems to imply that some value is needed for GST_CAT_DEFAULT. Since
> that define is inside MediaPlayerPrivateGStreamerMSE.cpp and not in the
> header (because it shouldn't be in the header in order to avoid clashing
> with local definitions when the header in included from other cpp files), it
> would remain undefined in the case of AppendPipeline, PlaybackPipeline and
> MediaSourceClientGStreamer. Therefore, I think we need to define it here by
> ourselves with the same value used in MediaPlayerPrivateGStreamerMSE.cpp:
> 
> #define GST_CAT_DEFAULT webkit_mse_debug

Yes, I didn't mean that we didn't need that. We definitely do, but for that to work with the already initialized category con *GStreamerMSE.cpp, you need to declare the one at *GStreamerMSE.cpp as _EXTERN. It's more clear and easy to abstract if you grep for GST_DEBUG_CATEGORY on WebKit code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170209/c32c8e02/attachment.html>