[Webkit-unassigned] [Bug 167990] Remove most cases of #if ENABLE(CACHE_PARTITIONING)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 8 09:00:35 PST 2017


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #300901|review?                     |review+
              Flags|                            |

--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 300901
  --> https://bugs.webkit.org/attachment.cgi?id=300901

View in context: https://bugs.webkit.org/attachment.cgi?id=300901&action=review

I love this!  rs=me when you get it compiling.

> Source/WebCore/loader/FrameLoader.cpp:1204
>          request.setDomainForCachePartition(m_frame.tree().top().document()->securityOrigin().domainForCachePartition());

Should this be using topOrigin?

> Source/WebCore/loader/cache/MemoryCache.cpp:562
>      static NeverDestroyed<String> httpString("http");

This can't really be necessary now that we have ASCIILiteral, right?

> Source/WebCore/platform/network/ResourceRequestBase.cpp:665
> +#else
> +    return domain;
> +#endif

Is this the right decision? Maybe we should we just return emptyString() if there is no PUBLIC_SUFFIX_LIST support? Or maybe we should #error if you enable ENABLE(CACHE_PARTITIONING) without ENABLE(PUBLIC_SUFFIX_LIST)?

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:97
> +    
>      revalidationRequest.makeUnconditional();

No need for this extra newline.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170208/c3f869dd/attachment.html>

More information about the webkit-unassigned mailing list