<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove most cases of #if ENABLE(CACHE_PARTITIONING)"
href="https://bugs.webkit.org/show_bug.cgi?id=167990">bug 167990</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #300901 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove most cases of #if ENABLE(CACHE_PARTITIONING)"
href="https://bugs.webkit.org/show_bug.cgi?id=167990#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove most cases of #if ENABLE(CACHE_PARTITIONING)"
href="https://bugs.webkit.org/show_bug.cgi?id=167990">bug 167990</a>
from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=300901&action=diff" name="attach_300901" title="patch">attachment 300901</a> <a href="attachment.cgi?id=300901&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=300901&action=review">https://bugs.webkit.org/attachment.cgi?id=300901&action=review</a>
I love this! rs=me when you get it compiling.
<span class="quote">> Source/WebCore/loader/FrameLoader.cpp:1204
> request.setDomainForCachePartition(m_frame.tree().top().document()->securityOrigin().domainForCachePartition());</span >
Should this be using topOrigin?
<span class="quote">> Source/WebCore/loader/cache/MemoryCache.cpp:562
> static NeverDestroyed<String> httpString("http");</span >
This can't really be necessary now that we have ASCIILiteral, right?
<span class="quote">> Source/WebCore/platform/network/ResourceRequestBase.cpp:665
> +#else
> + return domain;
> +#endif</span >
Is this the right decision? Maybe we should we just return emptyString() if there is no PUBLIC_SUFFIX_LIST support? Or maybe we should #error if you enable ENABLE(CACHE_PARTITIONING) without ENABLE(PUBLIC_SUFFIX_LIST)?
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:97
> +
>
> revalidationRequest.makeUnconditional();</span >
No need for this extra newline.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>