[Webkit-unassigned] [Bug 181010] A KVO change notification for WKWebView's _pinnedState property is not generated with a load of custom content is committed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181010

--- Comment #5 from Jeff Miller <jeffm at apple.com> ---
I misunderstood when the _pinnedState property changes. KVO works correctly when the page is scrolled, which is the most common case. I didn't realize that scrolling was necessary to generate the property change.

There's still a bug in WebPageProxy::didCommitLoadForFrame() where we aren't calling m_pageClient.pinnedStateWillChange()/m_pageClient.pinnedStateDidChange(), but only when the main frame has a custom content provider, which isn't a common scenario. I assume viewing a PDF would be an example of a custom content provider, but I haven't confirmed that.

The fix is straightforward, but I need to also write a test. I'm re-titling the bug to capture the actual issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171220/40960bc6/attachment.html>