[Webkit-unassigned] [Bug 122952] [GTK][WPE] Add NTLM authentication enabled API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122952

--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318247
  --> https://bugs.webkit.org/attachment.cgi?id=318247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318247&action=review

Hey Paul, can you try this patch please and report back as to whether it works or not? r=me if it works.

> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:338
> +    if (gInitialNTLMAuthenticationEnabled == enabled)
> +        return;

This is wrong. Did you copy this from somewhere (like ignore TLS errors)? It should be easy to see that this breaks if NTLM was initially enabled and later disabled, or vice-versa.

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1554
> + * is disabled, you need to call webkit_web_context_set_ntlm_authentication_enabled()

It's a run-on sentence. The two best options to fix it:

"disabled, and you"

"disabled. You"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170816/286f7f4e/attachment.html>