[Webkit-unassigned] [Bug 122952] [GTK][WPE] Add NTLM authentication enabled API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 16 09:30:58 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=122952

--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 318247
  --> https://bugs.webkit.org/attachment.cgi?id=318247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318247&action=review

>> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:338
>> +        return;
> 
> This is wrong. Did you copy this from somewhere (like ignore TLS errors)? It should be easy to see that this breaks if NTLM was initially enabled and later disabled, or vice-versa.

No, I didn't copy it, but you are right, this is wrong. Actually we always call first the Initial and then this, so it's always the same :-P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170816/29437fb2/attachment-0001.html>


More information about the webkit-unassigned mailing list