[Webkit-unassigned] [Bug 175426] REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 10 08:09:30 PDT 2017


--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Konstantin Tokarev from comment #10)
> >Are you saying that REQUIRED by *design* does not result in a fatal error, rather than some bug? 
> No, by design it should result in fatal error. However, I've found why it
> doesn't happen for WebP and GeoClue: package names are case-sensitive, so
> WebP != WEBP, and WEBP_FOUND being false is ignored because cmake looks for
> WebP_FOUND. We either need to rename FindWebP.cmake to FindWEBP.cmake and
> use find_package(WEBP), or use "WebP" spelling consistently. Same for other
> packages with mixed case names.


Just wow. Anyway, this is a separate bug report now. Bug #175427.

> As for FeatureSummary, I've added it to Qt port because of user request, it
> provides nice summary about what packages (required and optional) were found
> and which were not, and allows to add hints to user what is the purpose of
> these dependencies (so that user can know e.g. that disabling Geolocation is
> a way to get rid of GeoClue). See cmake documentation for more details. It
> can also replace our home-grown "Enabled features" list.

OK, we should definitely consider doing that in the future.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/84126c00/attachment.html>

More information about the webkit-unassigned mailing list