[Webkit-unassigned] [Bug 175426] REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 10 07:57:39 PDT 2017


--- Comment #10 from Konstantin Tokarev <annulen at yandex.ru> ---
>Are you saying that REQUIRED by *design* does not result in a fatal error, rather than some bug? 

No, by design it should result in fatal error. However, I've found why it doesn't happen for WebP and GeoClue: package names are case-sensitive, so WebP != WEBP, and WEBP_FOUND being false is ignored because cmake looks for WebP_FOUND. We either need to rename FindWebP.cmake to FindWEBP.cmake and use find_package(WEBP), or use "WebP" spelling consistently. Same for other packages with mixed case names.

As for FeatureSummary, I've added it to Qt port because of user request, it provides nice summary about what packages (required and optional) were found and which were not, and allows to add hints to user what is the purpose of these dependencies (so that user can know e.g. that disabling Geolocation is a way to get rid of GeoClue). See cmake documentation for more details. It can also replace our home-grown "Enabled features" list.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/835e17b4/attachment-0001.html>

More information about the webkit-unassigned mailing list