[Webkit-unassigned] [Bug 175211] [WTF] Move TextStream into WTF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 9 17:18:52 PDT 2017


Myles C. Maxfield <mmaxfield at apple.com> changed:

           What    |Removed                     |Added
 Attachment #317748|review?                     |review+
              Flags|                            |

--- Comment #34 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 317748
  --> https://bugs.webkit.org/attachment.cgi?id=317748

View in context: https://bugs.webkit.org/attachment.cgi?id=317748&action=review

I'm not an OWNER of the WebKit subproject, but just the change in pathnames shouldn't require an OWNER. Aside from the "WTF::", it looks good to me.

> Source/WebCore/dom/ViewportArguments.h:148
> +WTF::TextStream& operator<<(WTF::TextStream&, const ViewportArguments&);

The WTF style is to say "using WTF::Foo;" at the bottom of WTF headers. Doing this means you don't need "WTF::" sprayed over WebCore.

We chose a different style for PAL, and for now, we should keep the two styles different. We may wish to change the style for WTF some time in the future, but it should be its own discussion.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/c179442a/attachment.html>

More information about the webkit-unassigned mailing list