[Webkit-unassigned] [Bug 175211] [WTF] Move TextStream into WTF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 9 17:34:19 PDT 2017


--- Comment #35 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 317748
  --> https://bugs.webkit.org/attachment.cgi?id=317748

View in context: https://bugs.webkit.org/attachment.cgi?id=317748&action=review

>> Source/WebCore/dom/ViewportArguments.h:148
>> +WTF::TextStream& operator<<(WTF::TextStream&, const ViewportArguments&);
> The WTF style is to say "using WTF::Foo;" at the bottom of WTF headers. Doing this means you don't need "WTF::" sprayed over WebCore.
> We chose a different style for PAL, and for now, we should keep the two styles different. We may wish to change the style for WTF some time in the future, but it should be its own discussion.

With TextStream there were a lot of header files where it was forward declared. In those cases I moved the forward declaration into a WTF namespace within the header. There is a using declaration within TextStream to put it into a global scope. That's why there are only WTF::TextStream usages within header files but not within source files.

So in cases like this should it be forward declared without a namespace?

Just making sure since I'll have to rework the headers here.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170810/64941fae/attachment.html>

More information about the webkit-unassigned mailing list