[Webkit-unassigned] [Bug 175016] getClientRects doesn't work with list box option elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175016

--- Comment #25 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Darin Adler from comment #24)
> Comment on attachment 317218 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317218&action=review
> 
> > Source/WebCore/dom/Element.cpp:1166
> > +    if (!selectElement->renderer() || !is<RenderListBox>(selectElement->renderer()))
> > +        return std::nullopt;
> 
> I think we still need to null-check selectElement here, since
> ownerSelectElement can return nullptr.

Indeed, good catch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170805/fafad336/attachment.html>