[Webkit-unassigned] [Bug 175016] getClientRects doesn't work with list box option elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 4 09:57:21 PDT 2017


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #317218|review?                     |review+
              Flags|                            |

--- Comment #24 from Darin Adler <darin at apple.com> ---
Comment on attachment 317218
  --> https://bugs.webkit.org/attachment.cgi?id=317218
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317218&action=review

> Source/WebCore/dom/Element.cpp:1166
> +    if (!selectElement->renderer() || !is<RenderListBox>(selectElement->renderer()))
> +        return std::nullopt;

I think we still need to null-check selectElement here, since ownerSelectElement can return nullptr.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170804/2bd4556b/attachment.html>

More information about the webkit-unassigned mailing list