[Webkit-unassigned] [Bug 175139] Network cache should be usable as non-singleton

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175139

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317168|review?                     |review+
              Flags|                            |

--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 317168
  --> https://bugs.webkit.org/attachment.cgi?id=317168
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317168&action=review

r=me when it all builds

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:121
> +            NetworkCache::Cache::open(m_diskCacheDirectory, cacheOptions);

This feels too mysterious.  While I think you should store the Cache ref here, maybe for now just a comment explaining what's happening.

> Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:124
> +    NetworkCache::Cache::open(m_diskCacheDirectory, cacheOptions);

This feels too mysterious.  While I think you should store the Cache ref here, maybe for now just a comment explaining what's happening.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170803/119176bf/attachment.html>