[Webkit-unassigned] [Bug 175139] Network cache should be usable as non-singleton

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175139

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at webkit.org

--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 317168
  --> https://bugs.webkit.org/attachment.cgi?id=317168
patch

Nice! This also has the nice side effect that if we want to do targeted unit testing of it, it's much more straight forward.

One thing that might make things a little nicer, though could be left for later, is to make the NetworkProcess object, which is a singleton, own the NetworkCache instance, any make accessing the singleton be via NetworkProcess::singleton()->diskCache() (or whatever).  It would also make the calls to NetworkCache::Cache::open() that don't use their return values much less mysterious.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170803/886a385c/attachment-0001.html>