[Webkit-unassigned] [Bug 171450] Add a new function for getting the Git hash for a pure git directory.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 28 14:47:27 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=171450

--- Comment #3 from Kocsen Chung <kocsen_chung at apple.com> ---
Comment on attachment 308595
  --> https://bugs.webkit.org/attachment.cgi?id=308595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308595&action=review

>> Tools/Scripts/VCSUtils.pm:454
>> +        warn "$directory is a pure git repo.";
> 
> Is this debugging code?

I assume we also don't mind that git-svn repos will execute this code path.

> Tools/Scripts/VCSUtils.pm:456
> +        $command = "LC_ALL=C $command" if !isWindows();

Curious what is this for?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170428/dcb5132a/attachment.html>


More information about the webkit-unassigned mailing list