[Webkit-unassigned] [Bug 170959] [GTK] Building Webkit2Gtk without OpenGL fails.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 20:27:32 PDT 2017


--- Comment #5 from John Ralls <jralls at ceridwen.us> ---
> we only use <> style includes for headers from other projects.

That's a silly and non-standard-compliant rule. The difference between #include<foo> and #include "foo" is that the latter searches the current compilation unit's directory before searching the include path. All you accomplish by using quotes instead of brackets for files in different directories is to slow down your build.

> Instead please fix the include path.

No thanks. That's how bug 167343 happened.


> Hmm, this is concerning... I'd like another reviewer to say if this makes sense, please.

Yeah, concerning for me, too. But I lack the understanding of the code base--or of composting and GL, for that matter--necessary to be able to surgically separate the bits of the compositor that need GL from those that don't and to provide alternative methods where the only one currently available depends on GL.

> Check: https://webkit.org/contributing-code/

Yeah, I know. That's why I said "preliminary" and didn't set the review flag. This is a patch that works in the context of setting up a jhbuild tarball module but isn't ready for your code base; my intent was to show you the general scope of what's needed to build without GL. There are, BTW, 5 more patches for minor things like adjusting includes and macro-guarding function definitions to match the guards on the declarations in the header. I don't plan to open bugs and submit them because I don't think that fixing that stuff is a priority for you guys and I don't have the time needed to polish them up to make them acceptable for submission.

WebKit is too large a project and has too little test coverage (I tried to run `make check` and it aborted without running a single test because Xvfb isn't installed) for drive by patches. I don't have a couple of thousand hours lying around to learn your code base so I'm afraid that I've gone about as far as I can with this or anything else. I can get it to build, I'll include the rest of the patches in gtk-osx, and I've notified you of some problems. I completely understand that your focus is on supporting Gnome-on-Linux and that you don't have developer hours available to support other platforms.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170425/2cf56423/attachment.html>

More information about the webkit-unassigned mailing list