[Webkit-unassigned] [Bug 170959] [GTK] Building Webkit2Gtk without OpenGL fails.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 18:53:52 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170959

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 308015
  --> https://bugs.webkit.org/attachment.cgi?id=308015
Rearrange PlatformGTK.cmake so that OpenGL-dependent files are built only when ENABLE_OPENGL is true.

View in context: https://bugs.webkit.org/attachment.cgi?id=308015&action=review

> Source/WebCore/page/FrameView.cpp:106
> +#include <texmap/coordinated/TiledBackingStore.h>

Please don't do this, we only use <> style includes for headers from other projects. Instead please fix the include path. It looks like this directory needs to be in the include path for non-OpenGL builds.

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:49
> +#include <coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h>

Ditto.

> Source/cmake/OptionsGTK.cmake:272
> +SET_AND_EXPOSE_TO_BUILD(USE_COORDINATED_GRAPHICS TRUE)

Hmm, this is concerning... I'd like another reviewer to say if this makes sense, please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170425/b7214547/attachment-0001.html>


More information about the webkit-unassigned mailing list