[Webkit-unassigned] [Bug 155112] Web Inspector: Doesn't show size of compressed content correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 15 10:34:17 PDT 2017


--- Comment #26 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307080
  --> https://bugs.webkit.org/attachment.cgi?id=307080
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307080&action=review

I think we shouldn't check in tests with a FAIL expectation without some kind of explanation of what that means.  Also, I'm not sure the SPI exists everywhere.  Other than that, I think the network code looks good.

> Source/WebCore/platform/network/NetworkLoadMetrics.h:104
> +        requestHeaderBytesSent = std::nullopt;

Note: in another patch, we should replace the Seconds values that are -1 right now if there is no value with std::optional<Seconds>

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:625
> +    networkLoadMetrics.responseHeaderBytesReceived = 0;

Does the inspector have an indication that this resource was retrieved from the cache?  Does anyone care how many bytes were pulled from the cache?  It's obviously different from bytes received over the network, but maybe there should be a difference between a 0 byte resource and a resource from the cache.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170415/ef69a2ff/attachment.html>

More information about the webkit-unassigned mailing list