[Webkit-unassigned] [Bug 155112] Web Inspector: Doesn't show size of compressed content correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 15 16:59:00 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=155112

--- Comment #27 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 307080
  --> https://bugs.webkit.org/attachment.cgi?id=307080
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307080&action=review

>> LayoutTests/platform/mac/http/tests/inspector/network/resource-sizes-network-expected.txt:14
>> +    Actual: NaN
> 
> What's this about?

This is a platform expectation for Mac because as mentioned in the ChangeLog:

    Older versions of macOS will not have the new metrics...

Older cocoa platforms will be using the "estimated*" methods, which are tested here. If you want I could hide NaN output, but I'd still want to include platform expectations for older macOSes so that their code pathes are still tested.

>> Source/WebCore/platform/spi/cf/CFNetworkSPI.h:128
>> + at property (assign, readonly) NSInteger _requestHeaderBytesSent;
> 
> Is this SPI available on all platforms?

No, just out of range of the Review Tools is this condition wrapping this class extension:

    #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170415/3f164dff/attachment.html>


More information about the webkit-unassigned mailing list