[Webkit-unassigned] [Bug 169714] [jsc] Add missing MacroAssemblerMIPS::or32() implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 6 16:20:42 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=169714

Guillaume Emont <guijemont at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304573|review?                     |review-
              Flags|                            |

--- Comment #4 from Guillaume Emont <guijemont at igalia.com> ---
Comment on attachment 304573
  --> https://bugs.webkit.org/attachment.cgi?id=304573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304573&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:481
> +                m_assembler.addu(dataTempRegister, dataTempRegister, immTempRegister);

Wow! I did not pay attention when doing that. This obviously should be an orInsn not an addu! Will also fix in the new version. The fact that this mistake was not obvious when looking at test results makes me think that this code path (or the whole function) might never be used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170406/3a147829/attachment-0001.html>


More information about the webkit-unassigned mailing list