<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:guijemont@igalia.com" title="Guillaume Emont <guijemont@igalia.com>"> <span class="fn">Guillaume Emont</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc] Add missing MacroAssemblerMIPS::or32() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=169714">bug 169714</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #304573 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc] Add missing MacroAssemblerMIPS::or32() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=169714#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc] Add missing MacroAssemblerMIPS::or32() implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=169714">bug 169714</a>
from <span class="vcard"><a class="email" href="mailto:guijemont@igalia.com" title="Guillaume Emont <guijemont@igalia.com>"> <span class="fn">Guillaume Emont</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=304573&action=diff" name="attach_304573" title="Patch">attachment 304573</a> <a href="attachment.cgi?id=304573&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=304573&action=review">https://bugs.webkit.org/attachment.cgi?id=304573&action=review</a>
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:481
> + m_assembler.addu(dataTempRegister, dataTempRegister, immTempRegister);</span >
Wow! I did not pay attention when doing that. This obviously should be an orInsn not an addu! Will also fix in the new version. The fact that this mistake was not obvious when looking at test results makes me think that this code path (or the whole function) might never be used.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>