[Webkit-unassigned] [Bug 170444] WebGPU: implement ComputeCommandEncoder and related components

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 5 09:00:28 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170444

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |achristensen at apple.com

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 306167
  --> https://bugs.webkit.org/attachment.cgi?id=306167
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306167&action=review

This is really cool!
A few thoughts:
1) This needs to compile successfully on the iOS simulator for us to commit it.  See https://webkit.org/blog/3457/building-webkit-for-ios-simulator/ for help figuring out how.
2) I'm not sure if bounds checks or other validation steps will be needed.  Imagine a malicious web developer trying to overflow a buffer somewhere.
3) There should be a test for this.  I'm not sure what the status of the WebGPU tests are because it's in a prototyping state right now, but we will need to have tests that cover the new functionality to make sure it is accessible from javascript and has the correct behavior.  See LayoutTests/fast/canvas/webgpu which has some serious room for improvement.

> Source/WebCore/ChangeLog:8
> +        I implemented WebGPUComputeCommandEncoder and related components based on the WebGPU proposal.

Could you put a link to the proposal?  I haven't been following closely enough to know what you're talking about.

> Source/WebCore/ChangeLog:21
> +        If my understand is right, WebKit doesn't support promise attribute.

If we don't support it and it's needed, we might need to implement it.  Is something missing in the bindings generators?  See Source/WebCore/bindings/scripts/generate-bindings.pl and the other scripts there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170405/dc875074/attachment-0001.html>


More information about the webkit-unassigned mailing list