<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebGPU: implement ComputeCommandEncoder and related components"
href="https://bugs.webkit.org/show_bug.cgi?id=170444">bug 170444</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>achristensen@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebGPU: implement ComputeCommandEncoder and related components"
href="https://bugs.webkit.org/show_bug.cgi?id=170444#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebGPU: implement ComputeCommandEncoder and related components"
href="https://bugs.webkit.org/show_bug.cgi?id=170444">bug 170444</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=306167&action=diff" name="attach_306167" title="Patch">attachment 306167</a> <a href="attachment.cgi?id=306167&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=306167&action=review">https://bugs.webkit.org/attachment.cgi?id=306167&action=review</a>
This is really cool!
A few thoughts:
1) This needs to compile successfully on the iOS simulator for us to commit it. See <a href="https://webkit.org/blog/3457/building-webkit-for-ios-simulator/">https://webkit.org/blog/3457/building-webkit-for-ios-simulator/</a> for help figuring out how.
2) I'm not sure if bounds checks or other validation steps will be needed. Imagine a malicious web developer trying to overflow a buffer somewhere.
3) There should be a test for this. I'm not sure what the status of the WebGPU tests are because it's in a prototyping state right now, but we will need to have tests that cover the new functionality to make sure it is accessible from javascript and has the correct behavior. See LayoutTests/fast/canvas/webgpu which has some serious room for improvement.
<span class="quote">> Source/WebCore/ChangeLog:8
> + I implemented WebGPUComputeCommandEncoder and related components based on the WebGPU proposal.</span >
Could you put a link to the proposal? I haven't been following closely enough to know what you're talking about.
<span class="quote">> Source/WebCore/ChangeLog:21
> + If my understand is right, WebKit doesn't support promise attribute.</span >
If we don't support it and it's needed, we might need to implement it. Is something missing in the bindings generators? See Source/WebCore/bindings/scripts/generate-bindings.pl and the other scripts there.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>