[Webkit-unassigned] [Bug 170089] [jsc][mips] Add missing MacroAssembler functions after r214187

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 3 01:11:27 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=170089

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305523|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 305523
  --> https://bugs.webkit.org/attachment.cgi?id=305523
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305523&action=review

r=me with comment.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2462
> +    void loadFloat(ImplicitAddress address, FPRegisterID dest)
> +    {
> +        if (address.offset >= -32768 && address.offset <= 32767
> +            && !m_fixedWidth) {
> +            m_assembler.lwc1(dest, address.base, address.offset);
> +        } else {
> +            /*
> +               lui     addrTemp, (offset + 0x8000) >> 16
> +               addu    addrTemp, addrTemp, base
> +               lwc1    dest, (offset & 0xffff)(addrTemp)
> +               */
> +            m_assembler.lui(addrTempRegister, (address.offset + 0x8000) >> 16);
> +            m_assembler.addu(addrTempRegister, addrTempRegister, address.base);
> +            m_assembler.lwc1(dest, addrTempRegister, address.offset);
> +        }
> +    }

Looking the loadDouble code, we can see WTF_MIPS_ISA(1) guard.
Isn't it required here?

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2617
> +    }

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170403/87d3de77/attachment.html>


More information about the webkit-unassigned mailing list