<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089">bug 170089</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #305523 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [jsc][mips] Add missing MacroAssembler functions after r214187"
href="https://bugs.webkit.org/show_bug.cgi?id=170089">bug 170089</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=305523&action=diff" name="attach_305523" title="Patch">attachment 305523</a> <a href="attachment.cgi?id=305523&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=305523&action=review">https://bugs.webkit.org/attachment.cgi?id=305523&action=review</a>
r=me with comment.
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2462
> + void loadFloat(ImplicitAddress address, FPRegisterID dest)
> + {
> + if (address.offset >= -32768 && address.offset <= 32767
> + && !m_fixedWidth) {
> + m_assembler.lwc1(dest, address.base, address.offset);
> + } else {
> + /*
> + lui addrTemp, (offset + 0x8000) >> 16
> + addu addrTemp, addrTemp, base
> + lwc1 dest, (offset & 0xffff)(addrTemp)
> + */
> + m_assembler.lui(addrTempRegister, (address.offset + 0x8000) >> 16);
> + m_assembler.addu(addrTempRegister, addrTempRegister, address.base);
> + m_assembler.lwc1(dest, addrTempRegister, address.offset);
> + }
> + }</span >
Looking the loadDouble code, we can see WTF_MIPS_ISA(1) guard.
Isn't it required here?
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2617
> + }</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>