[Webkit-unassigned] [Bug 170391] Implement PromiseDeferredTimer for non CF based ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 2 22:38:56 PDT 2017


--- Comment #7 from Yusuke Suzuki <utatane.tea at gmail.com> ---
(In reply to Carlos Garcia Campos from comment #6)
> (In reply to Yusuke Suzuki from comment #5)
> > (In reply to Michael Catanzaro from comment #4)
> > > Comment on attachment 306055 [details]
> > > Patch
> > > 
> > > OK then, please rewrite to get rid of CFRunLoop.
> > 
> > A bit worried thing is that, current RunLoop & RunLoop::Timer do not have
> > the full features of CFRunLoop. For example, RunLoop is thread-safe,
> > functions can be called from the other thread. But RunLoop::Timer is only
> > available from the created thread. And current Heap's timers are touched
> > from the other thread.
> > 
> > So, I think we still need to use CFRunLoop right now. But at least, in
> > runRunLoop, we can just use RunLoop::run(). But for doWork function, we
> > still need CFRunLoop thing.
> Also note that iOS calls setRunLoop. Since CF timers already have a
> m_runLoop member I thought it was safer to use the member. I agree we could
> use RunLoop::run(), but since we need to keep the CF ifdefs for the stop, I
> think it's less confusing to have ifdefs for the run too.

OK, we should change & drop all the CF things when we use RunLoop & RunLoop::Timer thing exclusively.
Eventually, we should change current JSRunLoopTimer to accept RunLoop instead of CFRunLoopRef thing.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170403/62f5092c/attachment.html>

More information about the webkit-unassigned mailing list