<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement PromiseDeferredTimer for non CF based ports"
href="https://bugs.webkit.org/show_bug.cgi?id=170391#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement PromiseDeferredTimer for non CF based ports"
href="https://bugs.webkit.org/show_bug.cgi?id=170391">bug 170391</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>(In reply to Carlos Garcia Campos from <a href="show_bug.cgi?id=170391#c6">comment #6</a>)
<span class="quote">> (In reply to Yusuke Suzuki from <a href="show_bug.cgi?id=170391#c5">comment #5</a>)
> > (In reply to Michael Catanzaro from <a href="show_bug.cgi?id=170391#c4">comment #4</a>)
> > > Comment on <span class=""><a href="attachment.cgi?id=306055&action=diff" name="attach_306055" title="Patch">attachment 306055</a> <a href="attachment.cgi?id=306055&action=edit" title="Patch">[details]</a></span>
> > > Patch
> > >
> > > OK then, please rewrite to get rid of CFRunLoop.
> >
> > A bit worried thing is that, current RunLoop & RunLoop::Timer do not have
> > the full features of CFRunLoop. For example, RunLoop is thread-safe,
> > functions can be called from the other thread. But RunLoop::Timer is only
> > available from the created thread. And current Heap's timers are touched
> > from the other thread.
> >
> > So, I think we still need to use CFRunLoop right now. But at least, in
> > runRunLoop, we can just use RunLoop::run(). But for doWork function, we
> > still need CFRunLoop thing.
>
> Also note that iOS calls setRunLoop. Since CF timers already have a
> m_runLoop member I thought it was safer to use the member. I agree we could
> use RunLoop::run(), but since we need to keep the CF ifdefs for the stop, I
> think it's less confusing to have ifdefs for the run too.</span >
OK, we should change & drop all the CF things when we use RunLoop & RunLoop::Timer thing exclusively.
Eventually, we should change current JSRunLoopTimer to accept RunLoop instead of CFRunLoopRef thing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>