[Webkit-unassigned] [Bug 170351] JavaScriptCore: Do not use BLX for immediates (ARM-32)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170351

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306047|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #10 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 306047
  --> https://bugs.webkit.org/attachment.cgi?id=306047
The patch v2

I think this is very roundabout. Introducing a setting that you have to hack into the .asm file with a dummy if statement is super dirty. We should have the offlineasm program know what platform it's on.  That's better since we'll never have a fat binary that is both iOS and non-iOS-arm. As it stands the introduction of a new settings flag doubles the runtime of offlineasm for everyone. 

Would it be enough for you to detect in arm.rb if you're running on Darwin?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170401/b275a58c/attachment.html>