<html>
<head>
<base href="https://bugs.webkit.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351">bug 170351</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #306047 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - JavaScriptCore: Do not use BLX for immediates (ARM-32)"
href="https://bugs.webkit.org/show_bug.cgi?id=170351">bug 170351</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=306047&action=diff" name="attach_306047" title="The patch v2">attachment 306047</a> <a href="attachment.cgi?id=306047&action=edit" title="The patch v2">[details]</a></span>
The patch v2
I think this is very roundabout. Introducing a setting that you have to hack into the .asm file with a dummy if statement is super dirty. We should have the offlineasm program know what platform it's on. That's better since we'll never have a fat binary that is both iOS and non-iOS-arm. As it stands the introduction of a new settings flag doubles the runtime of offlineasm for everyone.
Would it be enough for you to detect in arm.rb if you're running on Darwin?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>