[Webkit-unassigned] [Bug 162705] Offline asm should not output masm assembly when using a x86_64 asm backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162705

--- Comment #26 from Mark Lam <mark.lam at apple.com> ---
I talked with Christopher offline.  This is how we should proceed:

1. Chris will add an optional --assembler=<assembler name> after the first 3 mandatory args that the offlineasm currently takes.
2. Chris will change isMSVC and isIntelSyntax to check if the optional --assembler is specified and --assembler=MASM.  Else, they will return false.
3. Chris will change the Windows build files that invoke the offlineasm to pass --assembler=MASM.  This will test that this patch worked as intended based on our current buildbot testing for Windows.

For Chris' cross compiling needs which may require build file changes, let's do that in a separate patch when their port is ready to be uploaded.  If anyone think we should approach this differently, please chime in.  Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160930/6b31698d/attachment.html>