[Webkit-unassigned] [Bug 162705] Offline asm should not output masm assembly when using a x86_64 asm backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162705

Christopher Reid <Christopher.reid at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290250|0                           |1
        is obsolete|                            |
 Attachment #290282|0                           |1
        is obsolete|                            |
 Attachment #290250|review?                     |
              Flags|                            |
 Attachment #290396|                            |review?
              Flags|                            |

--- Comment #25 from Christopher Reid <Christopher.reid at sony.com> ---
Created attachment 290396
  --> https://bugs.webkit.org/attachment.cgi?id=290396&action=review
Patch to remove the hash

Here's a patch I made to remove the hash comment for reference. 
It should work okay with cmake as cmake rebuilds based on changes in dependencies. 
I'm not working on mac so I don't know how xcode handles re-generation but it might always regenerate the parse tree with this change.

>Why not just add an optional argument you could use when building that would say "override the assembler to be xxx"?

When I first started looking at this task, I looked in to making this change as a command line option. Using the build rather than the ENV OS check to automatically determine the type of asm felt a lot cleaner to me.
There are a few changes I might have to make when dealing with arguments and I was wondering which approach I should take for them.
Right now the script expects input/output files in a specific order as the first 3 arguments.
I think I would have to either remake those arguments in to --FILE=X args or the new argument would need to always be after those arguments.
The input hash would have to take in to account the new possibility that the output asm can change based on an argument. 
To solve this, I would have to hash the arguments passed. If I make the change that arguments can be in any order, it's a small issue but I think arguments would need to be sorted before hashing since the order of arguments doesn't matter.

Should I continue along the lines of this patch or should I work towards making this a command line change?
I'm not sure which would be the best approach if wincairo is switching to clang. 
Does visual studio's clang use the masm assembler? I agree a command line option might be best if that's the case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160930/e32cb255/attachment-0001.html>