[Webkit-unassigned] [Bug 162669] [GStreamer] Can't play any video with GSTREAMER_GL enabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 30 09:13:15 PDT 2016


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #290334|                            |review?
              Flags|                            |

--- Comment #1 from Mario Sanchez Prada <mario at webkit.org> ---
Created attachment 290334
  --> https://bugs.webkit.org/attachment.cgi?id=290334&action=review
Patch proposal

It seems this was my fault after all, since I passed a X11 display type to gst_gl_display_egl_new_with_egl_display() instead of an EGLDisplay[1], because I (naively) took the code from the Wayland codepath without realizing that PlatformDisplayWayland::native() returns a valid EGLDisplay, while PlatformDisplayX11::native() does not.

Thus, simply passing the result of PlatformDisplay::eglDisplay() instead of PlatformDisplayX11::native() fixes the issue and I can now play video on my ARM device with GStreamerGL enabled \o/ 

Please review the attached patch, thanks!

[1] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L265
[2] https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L271

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160930/67194666/attachment.html>

More information about the webkit-unassigned mailing list