<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mario@webkit.org" title="Mario Sanchez Prada <mario@webkit.org>"> <span class="fn">Mario Sanchez Prada</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Can't play any video with GSTREAMER_GL enabled"
href="https://bugs.webkit.org/show_bug.cgi?id=162669">bug 162669</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #290334 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Can't play any video with GSTREAMER_GL enabled"
href="https://bugs.webkit.org/show_bug.cgi?id=162669#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Can't play any video with GSTREAMER_GL enabled"
href="https://bugs.webkit.org/show_bug.cgi?id=162669">bug 162669</a>
from <span class="vcard"><a class="email" href="mailto:mario@webkit.org" title="Mario Sanchez Prada <mario@webkit.org>"> <span class="fn">Mario Sanchez Prada</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=290334&action=diff" name="attach_290334" title="Patch proposal">attachment 290334</a> <a href="attachment.cgi?id=290334&action=edit" title="Patch proposal">[details]</a></span>
Patch proposal
It seems this was my fault after all, since I passed a X11 display type to gst_gl_display_egl_new_with_egl_display() instead of an EGLDisplay[1], because I (naively) took the code from the Wayland codepath without realizing that PlatformDisplayWayland::native() returns a valid EGLDisplay, while PlatformDisplayX11::native() does not.
Thus, simply passing the result of PlatformDisplay::eglDisplay() instead of PlatformDisplayX11::native() fixes the issue and I can now play video on my ARM device with GStreamerGL enabled \o/
Please review the attached patch, thanks!
[1] <a href="https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L265">https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L265</a>
[2] <a href="https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L271">https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L271</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>