[Webkit-unassigned] [Bug 162657] Test for long press on image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162657

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290258|review?                     |review+
              Flags|                            |

--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 290258
  --> https://bugs.webkit.org/attachment.cgi?id=290258
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290258&action=review

> Source/WebKit2/ChangeLog:3
> +        Test for long press on image

This title isn't really accurate. It's "Make it possible to test web-related user-interface features" or something.

> Source/WebKit2/ChangeLog:11
> +        Wrote a test for long press on an image, and used the sheet scraping functionality

s/Wrote/Add

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.h:75
> +- (NSArray *)currentAvailableActionStrings;

"strings" is a bit vague. "titles"?

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:224
> +    for (UIAlertAction *action in _interactionSheet.get().actions)
> +        [array addObject:action.title];

This gets localized text. Is this OK, or should we stringify the action enum values?

> LayoutTests/fast/events/touch/ios/long-press-on-image.html:33
> +					var actionDictionary = JSON.parse(result);

Please de-tab the file.

> LayoutTests/fast/events/touch/ios/long-press-on-image.html:42
> +						output += 'Available Actions: <br>';
> +						var arrayLength = actionStrings.length;
> +						for (var i = 0; i < arrayLength; i++) {
> +						    output += actionStrings[i] + '<br>';
> +						}

You could do this with an Array.join(separator).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160930/51db805c/attachment-0001.html>