<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Test for long press on image"
href="https://bugs.webkit.org/show_bug.cgi?id=162657">bug 162657</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #290258 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Test for long press on image"
href="https://bugs.webkit.org/show_bug.cgi?id=162657#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Test for long press on image"
href="https://bugs.webkit.org/show_bug.cgi?id=162657">bug 162657</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=290258&action=diff" name="attach_290258" title="Patch">attachment 290258</a> <a href="attachment.cgi?id=290258&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=290258&action=review">https://bugs.webkit.org/attachment.cgi?id=290258&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:3
> + Test for long press on image</span >
This title isn't really accurate. It's "Make it possible to test web-related user-interface features" or something.
<span class="quote">> Source/WebKit2/ChangeLog:11
> + Wrote a test for long press on an image, and used the sheet scraping functionality</span >
s/Wrote/Add
<span class="quote">> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.h:75
> +- (NSArray *)currentAvailableActionStrings;</span >
"strings" is a bit vague. "titles"?
<span class="quote">> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:224
> + for (UIAlertAction *action in _interactionSheet.get().actions)
> + [array addObject:action.title];</span >
This gets localized text. Is this OK, or should we stringify the action enum values?
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-on-image.html:33
> + var actionDictionary = JSON.parse(result);</span >
Please de-tab the file.
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-on-image.html:42
> + output += 'Available Actions: <br>';
> + var arrayLength = actionStrings.length;
> + for (var i = 0; i < arrayLength; i++) {
> + output += actionStrings[i] + '<br>';
> + }</span >
You could do this with an Array.join(separator).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>