[Webkit-unassigned] [Bug 162471] AX: iOS: Tapping <input> in Safari zooms in a bit when page has max scale = 1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162471

--- Comment #16 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 289665
  --> https://bugs.webkit.org/attachment.cgi?id=289665
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289665&action=review

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:332
>> +    if (!m_viewportConfiguration.allowsUserScalingIgnoringForceAlwaysScaling())
> 
> I literally cannot parse "allowsUserScalingIgnoringForceAlwaysScaling"

I'll try to rename this with ignoringForceAlwaysScalable

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:333
>> +        return m_page->pageScaleFactor();
> 
> This seems wrong. Shouldn't this return m_viewportConfiguration.maximumScale() ?

I'm not an expert on this but I copied the logic from WebPage::maximumPageScaleFactor()

>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2553
>> +    information.maximumScaleFactorIgnoringForceAlwaysScaling = maximumPageScaleFactorIgnoringForceAlwaysScaling();
> 
> Can we use "ignoringForceAlwaysScalable everywhere?

ok

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160929/2a72af6b/attachment-0001.html>