<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: iOS: Tapping <input> in Safari zooms in a bit when page has max scale = 1"
href="https://bugs.webkit.org/show_bug.cgi?id=162471#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: iOS: Tapping <input> in Safari zooms in a bit when page has max scale = 1"
href="https://bugs.webkit.org/show_bug.cgi?id=162471">bug 162471</a>
from <span class="vcard"><a class="email" href="mailto:n_wang@apple.com" title="Nan Wang <n_wang@apple.com>"> <span class="fn">Nan Wang</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289665&action=diff" name="attach_289665" title="patch">attachment 289665</a> <a href="attachment.cgi?id=289665&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289665&action=review">https://bugs.webkit.org/attachment.cgi?id=289665&action=review</a>
<span class="quote">>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:332
>> + if (!m_viewportConfiguration.allowsUserScalingIgnoringForceAlwaysScaling())
>
> I literally cannot parse "allowsUserScalingIgnoringForceAlwaysScaling"</span >
I'll try to rename this with ignoringForceAlwaysScalable
<span class="quote">>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:333
>> + return m_page->pageScaleFactor();
>
> This seems wrong. Shouldn't this return m_viewportConfiguration.maximumScale() ?</span >
I'm not an expert on this but I copied the logic from WebPage::maximumPageScaleFactor()
<span class="quote">>> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2553
>> + information.maximumScaleFactorIgnoringForceAlwaysScaling = maximumPageScaleFactorIgnoringForceAlwaysScaling();
>
> Can we use "ignoringForceAlwaysScalable everywhere?</span >
ok</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>