[Webkit-unassigned] [Bug 162705] Offline asm should not output masm assembly when using a x86_64 asm backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162705

--- Comment #9 from Mark Lam <mark.lam at apple.com> ---
(In reply to comment #7)
> (In reply to comment #6)
> 
> We're currently cross compiling on Windows with Clang. Because of our
> different platform, the ruby script is using an active backend of x86_64
> rather than x86_64_win but the isCompilingOnWindows is overriding this. This
> change is to make it so the script uses the active backend rather than just
> assuming masm when compiling on windows.

I would like to see an explanation like this put in the ChangeLog to record the motivation for this change.  Something like:

"When cross compiling on Windows with Clang, ..."

That said, I have further questions and comments in the patch.  I'll comment there shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160929/ec876437/attachment.html>