<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Offline asm should not output masm assembly when using a x86_64 asm backend"
href="https://bugs.webkit.org/show_bug.cgi?id=162705#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Offline asm should not output masm assembly when using a x86_64 asm backend"
href="https://bugs.webkit.org/show_bug.cgi?id=162705">bug 162705</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=162705#c7">comment #7</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=162705#c6">comment #6</a>)
>
> We're currently cross compiling on Windows with Clang. Because of our
> different platform, the ruby script is using an active backend of x86_64
> rather than x86_64_win but the isCompilingOnWindows is overriding this. This
> change is to make it so the script uses the active backend rather than just
> assuming masm when compiling on windows.</span >
I would like to see an explanation like this put in the ChangeLog to record the motivation for this change. Something like:
"When cross compiling on Windows with Clang, ..."
That said, I have further questions and comments in the patch. I'll comment there shortly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>