[Webkit-unassigned] [Bug 162678] New: woff2 upgrade introduces compiler warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162678

            Bug ID: 162678
           Summary: woff2 upgrade introduces compiler warnings
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org

Please fix compiler warnings before submitting patches! It seems unlikely that your compiler didn't warn about these:

[22/78] Building CXX object Source/Thi...MakeFiles/woff2.dir/src/woff2_dec.cc.o
../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::ReadWOFF2Header(const uint8_t*, size_t, woff2::{anonymous}::WOFF2Header*)’:
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1140:12: warning: unused variable ‘dst_offset’ [-Wunused-variable]
   uint64_t dst_offset = first_table_offset;
            ^~~~~~~~~~
../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::WriteHeaders(const uint8_t*, size_t, woff2::{anonymous}::RebuildMetadata*, woff2::{anonymous}::WOFF2Header*, woff2::WOFF2Out*)’:
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:34: warning: unused parameter ‘data’ [-Wunused-parameter]
 bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata,
                                  ^~~~
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:47: warning: unused parameter ‘length’ [-Wunused-parameter]
 bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata,
                                               ^~~~~~

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160928/050f360f/attachment-0001.html>