<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - woff2 upgrade introduces compiler warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=162678">162678</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>woff2 upgrade introduces compiler warnings
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Minor
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebKit Gtk
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mcatanzaro@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>bugs-noreply@webkitgtk.org
</td>
</tr></table>
<p>
<div>
<pre>Please fix compiler warnings before submitting patches! It seems unlikely that your compiler didn't warn about these:
[22/78] Building CXX object Source/Thi...MakeFiles/woff2.dir/src/woff2_dec.cc.o
../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::ReadWOFF2Header(const uint8_t*, size_t, woff2::{anonymous}::WOFF2Header*)’:
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1140:12: warning: unused variable ‘dst_offset’ [-Wunused-variable]
uint64_t dst_offset = first_table_offset;
^~~~~~~~~~
../../Source/ThirdParty/woff2/src/woff2_dec.cc: In function ‘bool woff2::{anonymous}::WriteHeaders(const uint8_t*, size_t, woff2::{anonymous}::RebuildMetadata*, woff2::{anonymous}::WOFF2Header*, woff2::WOFF2Out*)’:
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:34: warning: unused parameter ‘data’ [-Wunused-parameter]
bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata,
^~~~
../../Source/ThirdParty/woff2/src/woff2_dec.cc:1179:47: warning: unused parameter ‘length’ [-Wunused-parameter]
bool WriteHeaders(const uint8_t* data, size_t length, RebuildMetadata* metadata,
^~~~~~</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>