[Webkit-unassigned] [Bug 162608] [GTK] Update WOFF2 decoder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162608

--- Comment #8 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 289962
  --> https://bugs.webkit.org/attachment.cgi?id=289962
Patch, v3

View in context: https://bugs.webkit.org/attachment.cgi?id=289962&action=review

Yes, this looks good to me with Michael's comments addressed.

>> Source/WebCore/platform/graphics/WOFFFileFormat.cpp:100
>> +    bool Write(const void *data, size_t n)
> 
> void* data, not void *data
> 
> Is this a virtual method? If so you need to mark it override. If not, it should be named write with a lowercase W, since WebKit methods are camelCase.

Yes, they are pure virtual and should indeed be marked override.
https://github.com/google/woff2/blob/4e698b8c6c5e070d53c340db9ddf160e21070ede/src/woff2_out.h#L59

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160928/569a7e0e/attachment.html>