[Webkit-unassigned] [Bug 162636] [CMake] Add HAVE_LOCALTIME_R definition

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 27 15:14:36 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=162636

Don Olmstead <don.olmstead at am.sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|webkit-unassigned at lists.web |don.olmstead at am.sony.com
                   |kit.org                     |
 Attachment #290012|                            |review?
              Flags|                            |

--- Comment #1 from Don Olmstead <don.olmstead at am.sony.com> ---
Created attachment 290012
  --> https://bugs.webkit.org/attachment.cgi?id=290012&action=review
Patch

This patch will search for localtime_r through CMake. If its there then it will attempt to use it. If its not there then it defaults to localtime_s which is a C++11 extension to time.h. The difference between the two seems to be that localtime_r is thread safe. If that's not a concern then maybe it should just be localtime_s across the board.

MINGW appears to have the extension so I removed that. Windows still has its own localtime_s which reverses the parameters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160927/1bd6f386/attachment.html>


More information about the webkit-unassigned mailing list