<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:don.olmstead@am.sony.com" title="Don Olmstead <don.olmstead@am.sony.com>"> <span class="fn">Don Olmstead</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CMake] Add HAVE_LOCALTIME_R definition"
href="https://bugs.webkit.org/show_bug.cgi?id=162636">bug 162636</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>webkit-unassigned@lists.webkit.org
</td>
<td>don.olmstead@am.sony.com
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #290012 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CMake] Add HAVE_LOCALTIME_R definition"
href="https://bugs.webkit.org/show_bug.cgi?id=162636#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CMake] Add HAVE_LOCALTIME_R definition"
href="https://bugs.webkit.org/show_bug.cgi?id=162636">bug 162636</a>
from <span class="vcard"><a class="email" href="mailto:don.olmstead@am.sony.com" title="Don Olmstead <don.olmstead@am.sony.com>"> <span class="fn">Don Olmstead</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=290012&action=diff" name="attach_290012" title="Patch">attachment 290012</a> <a href="attachment.cgi?id=290012&action=edit" title="Patch">[details]</a></span>
Patch
This patch will search for localtime_r through CMake. If its there then it will attempt to use it. If its not there then it defaults to localtime_s which is a C++11 extension to time.h. The difference between the two seems to be that localtime_r is thread safe. If that's not a concern then maybe it should just be localtime_s across the board.
MINGW appears to have the extension so I removed that. Windows still has its own localtime_s which reverses the parameters.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>