[Webkit-unassigned] [Bug 162603] [GTK] Switch to use GMenu internally in the context menu implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162603

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289933|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 289933
  --> https://bugs.webkit.org/attachment.cgi?id=289933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289933&action=review

Thank you!

> Source/WebKit2/ChangeLog:8
> +        Switch to use GAction instead of GtkAtion internally, but still keeping a GtkAction associated to the GAction,

GtkAtion -> GtkAction

> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:160
> +    GUniquePtr<char> actionName(g_strdup_printf("action-%" G_GUINT64_FORMAT, ++actionID));

Nit: since it's a uint64_t rather than a guint64, I would print it with PRIu64

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h:64
> +    HashMap<unsigned long, void*> m_signalHandlers;

I don't understand, why use void* instead of GAction*? GAction* would obviously be safer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160927/39cff5aa/attachment.html>