<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Switch to use GMenu internally in the context menu implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=162603">bug 162603</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289933 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Switch to use GMenu internally in the context menu implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=162603#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Switch to use GMenu internally in the context menu implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=162603">bug 162603</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289933&action=diff" name="attach_289933" title="Patch">attachment 289933</a> <a href="attachment.cgi?id=289933&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289933&action=review">https://bugs.webkit.org/attachment.cgi?id=289933&action=review</a>
Thank you!
<span class="quote">> Source/WebKit2/ChangeLog:8
> + Switch to use GAction instead of GtkAtion internally, but still keeping a GtkAction associated to the GAction,</span >
GtkAtion -> GtkAction
<span class="quote">> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:160
> + GUniquePtr<char> actionName(g_strdup_printf("action-%" G_GUINT64_FORMAT, ++actionID));</span >
Nit: since it's a uint64_t rather than a guint64, I would print it with PRIu64
<span class="quote">> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h:64
> + HashMap<unsigned long, void*> m_signalHandlers;</span >
I don't understand, why use void* instead of GAction*? GAction* would obviously be safer.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>