[Webkit-unassigned] [Bug 162606] New: Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162606

            Bug ID: 162606
           Summary: Build fails for X11+EGL due to missing
                    gst_gl_display_x11_new_with_display()
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mario at webkit.org
                CC: magomez at igalia.com

In MediaPlayerPrivateGStreamerBase::ensureGstGLContext() [1] a call to either gst_gl_display_x11_new_with_display() or gst_gl_display_egl_new_with_egl_display() is made depending on whether we're building for X11 or Wayland:
  [...]
  #if PLATFORM(X11)
          m_glDisplay = GST_GL_DISPLAY(gst_gl_display_x11_new_with_display(downcast<PlatformDisplayX11>(sharedDisplay).native()));
  #elif PLATFORM(WAYLAND)
          m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayWayland>(sharedDisplay).native()));
  #endif
  [...]

However, this will fail when building for X11 with EGL (instead of GLX), since gst_gl_display_x11_new_with_display() is defined in /usr/include/gst/gl/x11/gstgldisplay_x11.h, which doesn't get included for EGL:

  [...]
  #include "GLContext.h"
  #if USE(GLX)
  #include "GLContextGLX.h"
  #include <gst/gl/x11/gstgldisplay_x11.h>
  #elif USE(EGL)
  #include "GLContextEGL.h"
  #include <gst/gl/egl/gstgldisplay_egl.h>
  #endif
  [...]

I believe a simple fix is to change the condition there to check for GLX or EGL, instead of X11 or WAYLAND.

[1] https://svn.webkit.org/repository/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160927/f1fe1a31/attachment.html>